search

timovv / notion-website-template

Make a personal website using Notion and GitHub Pages
136 stars 62 forks source link

Update README.md #9

Closed ocular-motor-lab closed 1 year ago

ocular-motor-lab commented 1 year ago

It took me a while to realize that the actions needed read and write permissions. So, I think it would be good to add it here.

timovv commented 1 year ago

Thanks for the contribution, and good spotting! This is new functionality for GitHub Actions, I think. Not sure when it was introduced, but it would break the script for sure.

Maybe instead of a note in the README, we could set the permissions in the main.yml action file. According to these docs, adding a section like

permissions:
  contents: write

might do the trick, and then there wouldn’t be any further manual intervention required. If you’re able to make that change I will happily merge that in — otherwise I will take a look later this week, when I get a chance.

Trost123 commented 1 year ago

Can be closed if https://github.com/timovv/notion-website-template/pull/11 is merged.

Trost123 commented 1 year ago

@ocular-motor-lab by the way, thanks for creating this PR. If you didn't bring up this topic here, I'd probably spend way more time trying to figure out this issue.

timovv commented 1 year ago

Thanks all, I have a terrible memory these days it seems, and never got around to actually do what I promised.