search

timower / rM2-stuff

Collection of reMarkable related apps, utilities and libraries.
GNU General Public License v3.0
125 stars 10 forks source link

Unfinished TODO can cause Bus error #17

Closed Eeems closed 8 months ago

Eeems commented 1 year ago

https://github.com/timower/rM2-stuff/blob/9126d7ff3093e5598342a7236f305e6331d9ed79/libs/rMlib/FrameBuffer.cpp#L199

If the framebuffer has a different resolution or virtual resolution than normal for any reason, you will get a Bus error crash when launching yaft or tilem. I assume rocket has the same flaw.

Eeems commented 9 months ago

@timower have you had a chance to look at this?

timower commented 8 months ago

Will your implementation support FBIOPUT_VSCREENINFO to request a window size?

timower commented 8 months ago

Actually, this should be fixed in 88e14de484b939eacf7ceb70dbb

Eeems commented 8 months ago

Will your implementation support FBIOPUT_VSCREENINFO to request a window size?

Not currently, but there is a TODO comment to add it eventually. Right now you'd need to use the window API to ask for it.

Actually, this should be fixed in 88e14de

Thanks, I'll have to test when I get back to this,