Add landscape mode

[kiwiz]

This PR adds support for landscape mode. Resolves #8.

Features:

• Detects the type-folio and triggers landscape mode
  • Hides the onscreen keyboard
• Sixel support

ToDo:

• Trigger rotation logic on keyboard attach/detach
• Investigate garbage on screen edges
  • Should clear entire screen when refreshing?

[Jayy001]

Will test this later today on the rm2

[timower]

Few nit picks, but thanks for the contribution!

[kiwiz]

Thanks for the review! Will clean up later today.

444b16c7d894cb9495d8f5dd474c79350389a319 is more of a personal pref - I'd be happy to get it upstream, but it does require manually triggering a refresh.

[timower]

444b16c is more of a personal pref - I'd be happy to get it upstream, but it does require manually triggering a refresh.

Yeah, let's leave it out for now. If you want it upstream I'd put it behind a flag (either a settings file or command line argument).

[FouzR]

Hey, could you guys tell how the keyboard is handled I was wondering how I could add my own shortcuts and such

also, I have tried running this PR, the first ver last night on my rM2, and it worked really well

[kiwiz]

There's no (user) configuration for the keyboard, so you'd have to make changes to the code for custom shortcuts. Modifying the pogo kernel module might be your best option.

[FouzR]

So I can't change anything specific on YAFT itself, but to the kernel module, which might affect xochitl?

[kiwiz]

You can, I'm just emphasizing that there's no configuration or anything.

[kiwiz]

Ok, I think this initial version is ready for review! I'd like some input on follow up work:

• Detecting when a keyboard is attached/detached
  • This would probably supercede the is_pogo_connected check in use currently
  • I took a quick look at InputManager, but it doesn't seem simple to pull out
• Adding support for a config file
  • Read in an INI? https://github.com/benhoyt/inih is one option
• Garbage on edges of screen
  • This happens because the app never clears the area outside the terminal area

[i-am-shodan]

There's no (user) configuration for the keyboard, so you'd have to make changes to the code for custom shortcuts. Modifying the pogo kernel module might be your best option.

If you are interested in putting the mapping of scancodes inside yaft there is a lookup table here (one for UK one for US) that can convert the input from the folio keyboard into the correct logical output.

https://github.com/i-am-shodan/ReTerm/blob/master/src/ReTerm/Settings/DefaultKeyboardLayouts.cs

[FouzR]

I kinda went the "modifying pogo module" route 😅

See here, where I repurposed someone else's fork of the kpad file, which was in DVROAK, into QWERTY

[i-am-shodan]

I kinda went the "modifying pogo module" route 😅

See here, where I repurposed someone else's fork of the kpad file, which was in DVROAK, into QWERTY

Scares the living daylights out of me

[FouzR]

I kinda went the "modifying pogo module" route 😅

See here, where I repurposed someone else's fork of the kpad file, which was in DVROAK, into QWERTY

Scares the living daylights out of me

Honestly, it was only a matter of finding out which key was which, and changing it accordingly.

[i-am-shodan]

I've been testing this PR, great work it looks really good. Some issues/comments/ideas:

• Keyboard handling needs work. I haven't been able to get the layout to exactly match the physical layout even when compiling a new pogo driver.
• Key repeat doesn't work either. Might be easier to pull the official keyboard handling code from here https://github.com/reMarkable/epaper-qpa which supports all the different keymaps and presumable key repeat as well.
• Most people are going to struggle typing in even simple commands without many simple characters being overlaid. Back slash, square, curly braces and backtick are probably the big ones.
• If further keyboard handling does make it in it might be worth repurposing Alt/Opt to show a help screen detailing any additional keys