Closed kiwiz closed 1 year ago
Will test this later today on the rm2
Few nit picks, but thanks for the contribution!
Thanks for the review! Will clean up later today.
444b16c7d894cb9495d8f5dd474c79350389a319 is more of a personal pref - I'd be happy to get it upstream, but it does require manually triggering a refresh.
444b16c is more of a personal pref - I'd be happy to get it upstream, but it does require manually triggering a refresh.
Yeah, let's leave it out for now. If you want it upstream I'd put it behind a flag (either a settings file or command line argument).
Hey, could you guys tell how the keyboard is handled I was wondering how I could add my own shortcuts and such
also, I have tried running this PR, the first ver last night on my rM2, and it worked really well
There's no (user) configuration for the keyboard, so you'd have to make changes to the code for custom shortcuts. Modifying the pogo
kernel module might be your best option.
So I can't change anything specific on YAFT itself, but to the kernel module, which might affect xochitl?
You can, I'm just emphasizing that there's no configuration or anything.
Ok, I think this initial version is ready for review! I'd like some input on follow up work:
is_pogo_connected
check in use currentlyInputManager
, but it doesn't seem simple to pull outThere's no (user) configuration for the keyboard, so you'd have to make changes to the code for custom shortcuts. Modifying the
pogo
kernel module might be your best option.
If you are interested in putting the mapping of scancodes inside yaft there is a lookup table here (one for UK one for US) that can convert the input from the folio keyboard into the correct logical output.
https://github.com/i-am-shodan/ReTerm/blob/master/src/ReTerm/Settings/DefaultKeyboardLayouts.cs
I kinda went the "modifying pogo module" route 😅
See here, where I repurposed someone else's fork of the kpad file, which was in DVROAK, into QWERTY
I kinda went the "modifying pogo module" route 😅
See here, where I repurposed someone else's fork of the kpad file, which was in DVROAK, into QWERTY
Scares the living daylights out of me
I kinda went the "modifying pogo module" route 😅
See here, where I repurposed someone else's fork of the kpad file, which was in DVROAK, into QWERTY
Scares the living daylights out of me
Honestly, it was only a matter of finding out which key was which, and changing it accordingly.
I've been testing this PR, great work it looks really good. Some issues/comments/ideas:
This PR adds support for landscape mode. Resolves #8.
Features:
ToDo: