Assorted QoL changes - Githubissues

timower / rM2-stuff

Collection of reMarkable related apps, utilities and libraries.

GNU General Public License v3.0

125 stars 10 forks source link

Assorted QoL changes #20

Closed kiwiz closed 1 year ago

kiwiz commented 1 year ago

Implemented

Fixes physical keyboard repeat
- This was broken by my previous PR
Handle screen input rotation
- Not sure if gestures are handled correctly, but I'm not sure if any gestures are actually in use?
Clear garbage on screen edges
Support for F1 - F12 keys

Todo

~Dynamically detect when keyboard is attached~ Tabling for now
~Config support~
~BUG: Keyboard visibility state is broken~
- Repro: Trigger the keyboard hide/show code 3 times.
~Fix F1 - F12 support. May need to update the terminfo for this to work properly? Help with this would be appreciated~

timower commented 1 year ago

Not sure if gestures are handled correctly, but I'm not sure if any gestures are actually in use?

Two finger scroll should work, but it is kind of flaky.

timower commented 1 year ago

I noticed that hovering over the screen with the pen triggers inputs. IMO, only physically tapping the screen should report a mouse input.

The idea was to allow mouse moves when hovering. That way you could drag something by touching the screen while moving the pen. Though I don't use the mouse integration that much, so I'm fine with either implementation or a config option.

kiwiz commented 1 year ago

The idea was to allow mouse moves when hovering. That way you could drag something by touching the screen while moving the pen. Though I don't use the mouse integration that much, so I'm fine with either implementation or a config option.

~Ah, I see. In that case, I'll see if I can require a physical touch before events start getting fired (if that's not already the case).~ It looks like this is already working properly.

timower commented 1 year ago

BUG: Keyboard visibility state is broken

Just fixed this, along with pogo detection in yaft_auto, I'll get my folio tomorrow to verify if it works.

kiwiz commented 1 year ago

Sweet, hope you enjoy it!

I'll open up a separate PR for the config support (unless if you'd like to take a stab at it) and continue investigating the F# keys.

kiwiz commented 1 year ago

This should hopefully fix the F keys

Looks like F6 - F12 work (in htop, at least)

kiwiz commented 1 year ago

With the changes above, F5 - F12 work.

kiwiz commented 1 year ago

Ah, indices were off on the write_ss3 function. All F# keys work now!