search

timower / rM2-stuff

Collection of reMarkable related apps, utilities and libraries.
GNU General Public License v3.0
125 stars 10 forks source link

rm2fb issues when switching apps in remux or oxide #44

Closed Eeems closed 2 months ago

Eeems commented 2 months ago

As part of investigating integrating your version of rm2fb into toltec for 3.5.2 and 3.8.2 support, I've discovered what I would consider a blocking bug.

When the launchers switch between running applications they will often fail to fully render the saved screen for the application. This behaviour does not happen with the upstream rm2fb on older OS versions.

You can find some screenshots of the issue in the following comments:

timower commented 2 months ago

I can reproduce issues with part of the screen being blank in the calculator app. I think they changed how they interpret the colors in the framebuffer (which bits being which color), but I'll have to confirm. Does the attached video match what you're seeing?

https://drive.google.com/file/d/1lmqqbrVg5fe8iFm2We3LW5mk8TkusyDg/view?usp=sharing

Eeems commented 2 months ago

That does look like what I'm seeing, just with a different mechanism to trigger it.

timower commented 2 months ago

Turns out I was hooking the QImage constructor when I shouldn't. So easy fix

StarNumber12046 commented 2 months ago

Sill also seems to not display anything

StarNumber12046 commented 2 months ago

actually, I'll upload a screenshot (with bufshot over rm2fb client) and a picture of the rM with sill supposedly running fb PXL_20240529_132646733

Eeems commented 2 months ago

actually, I'll upload a screenshot (with bufshot over rm2fb client) and a picture of the rM with sill supposedly running

I'm assuming you built your own copy of rm2fb with the changes timowers created and this is what you are seeing? Did you include any of the changes made in the toltec PR to fix up the environment at all?

StarNumber12046 commented 2 months ago

No I'm using latest release

Il mer 29 mag 2024, 18:19 Nathaniel van Diepen @.***> ha scritto:

actually, I'll upload a screenshot (with bufshot over rm2fb client) and a picture of the rM with sill supposedly running fb.png (view on web) https://github.com/timower/rM2-stuff/assets/64470722/5bc706d0-866f-4b21-870b-1264df8ad1d0 PXL_20240529_132646733.jpg (view on web) https://github.com/timower/rM2-stuff/assets/64470722/eaae9191-e71c-44d8-97b8-84480a910aa2

I'm assuming you built your own copy of rm2fb with the changes timowers created and this is what you are seeing? Did you include any of the changes made in the toltec PR to fix up the environment at all?

— Reply to this email directly, view it on GitHub https://github.com/timower/rM2-stuff/issues/44#issuecomment-2137802479, or unsubscribe https://github.com/notifications/unsubscribe-auth/APL35QVHQTV554YCHI3BDH3ZEX52BAVCNFSM6AAAAABIISHBI2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMZXHAYDENBXHE . You are receiving this because you commented.Message ID: @.***>

StarNumber12046 commented 2 months ago

I'll test it later today

Il mer 29 mag 2024, 18:20 StarNumber Official < @.***> ha scritto:

No I'm using latest release

Il mer 29 mag 2024, 18:19 Nathaniel van Diepen @.***> ha scritto:

actually, I'll upload a screenshot (with bufshot over rm2fb client) and a picture of the rM with sill supposedly running fb.png (view on web) https://github.com/timower/rM2-stuff/assets/64470722/5bc706d0-866f-4b21-870b-1264df8ad1d0 PXL_20240529_132646733.jpg (view on web) https://github.com/timower/rM2-stuff/assets/64470722/eaae9191-e71c-44d8-97b8-84480a910aa2

I'm assuming you built your own copy of rm2fb with the changes timowers created and this is what you are seeing? Did you include any of the changes made in the toltec PR to fix up the environment at all?

— Reply to this email directly, view it on GitHub https://github.com/timower/rM2-stuff/issues/44#issuecomment-2137802479, or unsubscribe https://github.com/notifications/unsubscribe-auth/APL35QVHQTV554YCHI3BDH3ZEX52BAVCNFSM6AAAAABIISHBI2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMZXHAYDENBXHE . You are receiving this because you commented.Message ID: @.***>

Eeems commented 2 months ago

The latest release does not contain the changed code yet.

timower commented 2 months ago

I'll make a release with the fix, then it'll be easier to verify

StarNumber12046 commented 2 months ago

When the launchers switch between running applications they will often fail to fully render the saved screen for the application. This behaviour does not happen with the upstream rm2fb on older OS versions.

This seems to be the same root cause as yaft having its keyboard disappear

StarNumber12046 commented 2 months ago

(it is now fixed)

timower commented 2 months ago

How are you getting sill to run? For me it fails with:

thread 'main' panicked at 'Failed to open swtfb shared buffer: Os { code: 2, kind: NotFound, message: "No such file or directory" }', /root/.cargo/git/checkouts/libremarkable-e1fa5419bec94e16/5b9316a/src/framebuffer/core.rs:128:18

Because it tries to re-implement the rm2fb client protocol

StarNumber12046 commented 2 months ago

image image

StarNumber12046 commented 2 months ago

https://github.com/toltec-dev/toltec/pull/860#issuecomment-2130531958

raisjn commented 2 months ago

Because it tries to re-implement the rm2fb client protocol

@timower: swtfb.01 is used by rm2fb in /dev/shm , i believe you changed it to rm2fb.01 (not sure if you changed it back yet) in your implementation. likely gonna break libremarkable apps (sill) and also bufshot (thanks @Eeems for finding this)