search

timoxley / keycode

Convert between keyboard keycodes and keynames and vice versa.
MIT License
455 stars 62 forks source link

#28 Updated .d.ts file to avoid exported external package typings file issues #30

Closed cmj91uk closed 8 years ago

cmj91uk commented 8 years ago

This seems to sort the problem out for me. I'm not 100% sure of the full implications of making this change to the .d.ts file.

This is my first PR so if there are any issues please let me know and I can try and get them sorted out if you are happy to merge!

timoxley commented 8 years ago

@artfuldev can you please review this?

artfuldev commented 8 years ago

Sorry, but I think exporting modules is not the recommended way. The typescript compiler itself generates a different set of declarations. I've proposed a separate pull request #31

cmj91uk commented 8 years ago

Not a problem... this was based on a bit of research I did online and appeared to solve the issue. I've tried out the changes in your separate pull request and it certainly seems to resolve the issue I originally raised when implemented locally.

artfuldev commented 8 years ago

@cmj91uk That's great, thanks for your feedback. :+1: