search

timqian / chart.xkcd

xkcd styled chart lib
https://timqian.com/chart.xkcd/
MIT License
7.61k stars 200 forks source link

New charts #10

Open jwilber opened 4 years ago

jwilber commented 4 years ago

Hey! Great library. Would it be cool if I made a PR for some new charts at some point? e.g.

timqian commented 4 years ago

Thanks for the interest! It is very welcomed. But currently there are some duplications and other issues in the code, I will tidy up the code as soon as possible. When it is ready to accept PR I will inform you.

Is it OK to assign issues about the new chart types you mentioned?

jwilber commented 4 years ago

@timqian no worries! And yes, feel free to tag me :)

WriteCodeEveryday commented 4 years ago

@timqian if you want help, I would love to help out for a sankey diagram... not even sure what charting library you're using :)

jwilber commented 4 years ago

@WriteCodeEveryday looks like everything is wrapping d3