search

timqian / gql-generator

Generate queries from graphql schema, used for writing api test.
MIT License
374 stars 93 forks source link

Backwards compatible arguments dedupe #11

Closed robCrawford closed 5 years ago

robCrawford commented 5 years ago

This is a backwards compatible fix for argument collisions. An incrementing index is added to only the duplicate var names.

robCrawford commented 5 years ago

@timqian turns out I will need to fix these collisions for my integration tests. What are your thoughts?

timqian commented 5 years ago

@robCrawford Sorry for the late reply, I am a little busy these days, can you also update this part of doc: https://github.com/modelo/gql-generator#notice to describe this behavior? and I will review and merge the PR asap

robCrawford commented 5 years ago

No problem, I rewrote the notice section a little hope you don't mind. I had a little trouble with your lint settings, maybe you can just change the lint config?

timqian commented 5 years ago

Thanks, the new version is pushed to npm