timqian / gql-generator

Generate queries from graphql schema, used for writing api test.
MIT License
374 stars 93 forks source link

Crash if input file is bigger than ~26kb #15

Closed Murd0kai closed 5 years ago

Murd0kai commented 5 years ago

The tool is awesome, thank you for writing it. Sadly if input schema.graphql (with all mutations and queries) is bigger than ~26kb there is a crash with output:

/usr/local/lib/node_modules/gql-generator/node_modules/graphql/language/lexer.js:302
  throw (0, _error.syntaxError)(source, pos, unexpectedCharacterMessage(code));
  ^
GraphQLError: Syntax Error: Cannot parse the unexpected character <EOF>.
    at syntaxError (/usr/local/lib/node_modules/gql-generator/node_modules/graphql/error/syntaxError.js:24:10)
    at readToken (/usr/local/lib/node_modules/gql-generator/node_modules/graphql/language/lexer.js:302:32)
    at Object.lookahead (/usr/local/lib/node_modules/gql-generator/node_modules/graphql/language/lexer.js:61:43)
    at Object.advanceLexer [as advance] (/usr/local/lib/node_modules/gql-generator/node_modules/graphql/language/lexer.js:52:33)
    at skip (/usr/local/lib/node_modules/gql-generator/node_modules/graphql/language/parser.js:1284:11)
    at many (/usr/local/lib/node_modules/gql-generator/node_modules/graphql/language/parser.js:1349:11)
    at parseEnumValuesDefinition (/usr/local/lib/node_modules/gql-generator/node_modules/graphql/language/parser.js:945:50)
    at parseEnumTypeDefinition (/usr/local/lib/node_modules/gql-generator/node_modules/graphql/language/parser.js:930:16)
    at parseTypeSystemDefinition (/usr/local/lib/node_modules/gql-generator/node_modules/graphql/language/parser.js:669:16)
    at parseDefinition (/usr/local/lib/node_modules/gql-generator/node_modules/graphql/language/parser.js:143:16)
Murd0kai commented 5 years ago

I'm sorry, the problem was in multiline comments like

"""

some

commment

"""

after removing them everything works like a charm