Feature Exclude Deprecated Fields

timqian / gql-generator

Generate queries from graphql schema, used for writing api test.

MIT License

374 stars 93 forks source link

Feature Exclude Deprecated Fields #18

Closed bonham000 closed 5 years ago

bonham000 commented 5 years ago

This PR:

Address #16 and provide default behavior to exclude @deprecated fields from gql-generator output and an optional command line argument to include @deprecated fields if the user wants to opt out of this behavior.

Notes:

I think I found the right places to add filters on the isDeprecated flag. If not I'm happy to adjust the code!

timqian commented 5 years ago

Hi @bonham000 Thanks for your contribution, the code looks good to me.

Can you also add a new test case for this feature here? https://github.com/modelo/gql-generator/blob/master/test/index.js

bonham000 commented 5 years ago

Sure, @timqian no problem - I'll add a test for it!

bonham000 commented 5 years ago

Hi @timqian I added some tests to cover a deprecated query, mutation, and a deprecated field and tested the default behavior and also the behavior of opting in to include the deprecated fields with the --includeDeprecatedFields flag.

timqian commented 5 years ago

Thanks, @bonham000 I will test it with more complicated schemas and release soon today

bonham000 commented 5 years ago

Great, thanks @timqian!