search

timraay / HLLLogUtilities

A Discord bot that makes it easy to capture and export logs from your HLL servers
MIT License
8 stars 4 forks source link

Missing players when 20th char in name is a space #9

Open timraay opened 1 year ago

timraay commented 1 year ago

HLL truncates names longer than 20 characters. If the 20th character in someone's name is a space this becomes a significant problem, because most RCON commands expect the player's name yet fail to recognize the player when their truncated name ends with a space.

For HLU this means that the playerinfo command cannot be ran. In result, it will ignore the player completely. Below is the relevant code.

https://github.com/timraay/HLLLogUtilities/blob/baae43bb6a380fb8a559dc5c888ab3a4cc9ddbad/lib/rcon.py#L285-L288

A basic solution would be to simply work without the additional information provided by the playerinfo command. So when the 20th character is a space, we skip the playerinfo command but don't discard the player data altogether.

Using the player's full name still works however. So we may be able to perform a one-time Steam Source Query call to get the player's info. I already have a working implementation of that protocol around somewhere. If someone is willing to take on the challenge of implementing this I can open a PR and commit what I have.

timraay commented 1 year ago

I take back the last bit about using Source query, since we don't know the server's query port.

timraay commented 1 year ago

Workaround has been implemented. If they ever fix this bug or allow for a better workaround I may look at this again.

FlorianSW commented 1 year ago

Should be the same as: https://github.com/MarechJ/hll_rcon_tool/issues/116 T17 promised me they fixed that issue and it will be released with the next update. Not sure, what they did, but let's see :)