Closed cimentadaj closed 4 years ago
The PR triggers Appveyor fail, but guess this no longer matters. Will merge in ca 20 min and see
On Thu, May 28, 2020 at 12:24 PM Jorge Cimentada notifications@github.com wrote:
Once you accept it, I think it will run GH actions for merge. Let's wait until it finishes, check that everything passes and then the GH actions badge on the README just turn green (because it's pointing to your GH actions for DDSQL).
You can view, comment on, or merge this pull request online at:
https://github.com/timriffe/DDSQLtools/pull/29 Commit Summary
- Fixes vignette code chunk
- Tries to get gh actions to work
- Tries to fix GH actions
- Simplifies gh actionssss
- ....
- Tries to fix the macOS version
- Fixes check with some columns that are now removed from the API
- Adds test for checking the isComplete = 'Total' by default
- Tries to fix macOS tests
- Tries to fix ubuntu
- Ubuntu...
- Ubuntuuuu
- ubuu
- Sets gh actions default
- Update check-standard.yaml
- Tries removing linux sysdep
- Almost here with ubuntu
- Ubuuuu
- Tries to install demotools directly
- Tries to install x11
- Tries to fix mac
- Remove ungroup to see if rgl doesn't get installed
- Tries CI with tic
- Tries to set CRAN repo
- CRAN repo
- Pushes tic file
- Tries to install X11 on tic
- Tries to install rgl up front
- Tries to install rgl external software
- Trivial commit
- External rgl software
- Matches DemoTools external software from travis
- Tries to fix rgl with DISPLAY=:99
- Fixes typo environment
- Tries to set DISPLAY in other step of GH actions
- Moves DISPLAY to ignore wingows in install
- Fixing windows typo names
- Tries to fix windows name again
- Makes script run specific to no macos
- Tries to fix windows
- ...
- Windowwwss
- Tries to custom fix
- Pleasssee
- Let's check it works!
- Merge branch 'master' of https://github.com/timriffe/DDSQLtools
- Update README.md
- Deletes travis/appveyor
File Changes
- M .Rbuildignore https://github.com/timriffe/DDSQLtools/pull/29/files#diff-bc92b187c74649b3e0a039784ff93b39 (3)
- D .github/workflows/R-CMD-check.yaml https://github.com/timriffe/DDSQLtools/pull/29/files#diff-9bfee71065492f63457918efcd912cf2 (24)
- A .github/workflows/main.yml https://github.com/timriffe/DDSQLtools/pull/29/files#diff-90829e76e906f1c73140c7ded7e1b268 (206)
- D .travis.yml https://github.com/timriffe/DDSQLtools/pull/29/files#diff-354f30a63fb0907d4ad57269548329e3 (34)
- M DESCRIPTION https://github.com/timriffe/DDSQLtools/pull/29/files#diff-35ba4a2677442e210c23a00a5601aba3 (2)
- M R/Utils_Gets.R https://github.com/timriffe/DDSQLtools/pull/29/files#diff-868dccd7a2edf50ffea588a9060f046c (9)
- M README.md https://github.com/timriffe/DDSQLtools/pull/29/files#diff-04c6e90faac2675aa89e2176d2eec7d8 (4)
- D appveyor.yml https://github.com/timriffe/DDSQLtools/pull/29/files#diff-180360612c6b8c4ed830919bbb4dd459 (51)
- M man/DDSQLtools.data.Rd https://github.com/timriffe/DDSQLtools/pull/29/files#diff-27bcb159563e37e0a1ae48c84265e650 (4)
- M patrick_answers.R https://github.com/timriffe/DDSQLtools/pull/29/files#diff-dd5145c7e5aeecff2de59bc28de5e806 (90)
- M tests/testthat/test-API.R https://github.com/timriffe/DDSQLtools/pull/29/files#diff-6e118e63902ea35f5601839e6c677433 (17)
- A tic.R https://github.com/timriffe/DDSQLtools/pull/29/files#diff-07a2008075c734d1c16f79eb98507798 (8)
- M vignettes/Downloading-UNPD-data-into-R.Rmd https://github.com/timriffe/DDSQLtools/pull/29/files#diff-f0f3d68661ea4c0304fc5ec5f045ca69 (7)
Patch Links:
- https://github.com/timriffe/DDSQLtools/pull/29.patch
- https://github.com/timriffe/DDSQLtools/pull/29.diff
— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/timriffe/DDSQLtools/pull/29, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAG43GZD3HN4FWIPXZ5H7SLRTY3VLANCNFSM4NM6QYKQ .
Once you accept it, I think it will run GH actions for merge. Let's wait until it finishes, check that everything passes and then the GH actions badge on the README just turn green (because it's pointing to your GH actions for DDSQL).