Adds datasources endpoint and adds new params to get_recorddata

timriffe / DDSQLtools

DemoData SQL tools. Wrappers for the DemoTools package to work with UNPD SQL data format

https://timriffe.github.io/DDSQLtools

Other

5 stars 1 forks source link

Adds datasources endpoint and adds new params to get_recorddata #37

Closed cimentadaj closed 4 years ago

cimentadaj commented 4 years ago

Small fixes to which arguments are translatable between numbers/strings
Creates get_datasources
Updates docs to make it more maintainable (excludes the list of all params in the docs because these change and are being added. Instead I reference the user to swagger, where all params are updated automatically every time Dennis changes stuff)
Cleans up old code from package (if we want to go back we'll use git, they're tracked in history)
Adds extra params to get_recorddata

Tests are failing due to some endpoints being down. Dennis is notified so this is minor. Aside from that, all else is passing.

timriffe commented 4 years ago

merged, but getting some errors on all systems.

On Thu, Nov 5, 2020 at 11:57 AM Jorge Cimentada notifications@github.com wrote:

@cimentadaj https://github.com/cimentadaj requested your review on: #37 https://github.com/timriffe/DDSQLtools/pull/37 Adds datasources endpoint and adds new params to get_recorddata.

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/timriffe/DDSQLtools/pull/37#event-3961783276, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAG43G6ZXRFKEVISRK3ZOZ3SOKAKDANCNFSM4TLGTRHA .

cimentadaj commented 4 years ago

Yep, expected. Tests are failing due to some endpoints being down. Dennis is notified so this is minor. Aside from that, all else is passing.

timriffe commented 4 years ago

word

On Thu, Nov 5, 2020 at 2:39 PM Jorge Cimentada notifications@github.com wrote:

Yep, expected. Tests are failing due to some endpoints being down. Dennis is notified so this is minor. Aside from that, all else is passing.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/timriffe/DDSQLtools/pull/37#issuecomment-722383423, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAG43G5JPX3Z3YCZ3BJNTVDSOKTHPANCNFSM4TLGTRHA .