search

timriffe / DemoTools

Tools for the evaluation, adjustment, and standardization of demographic data
https://timriffe.github.io/DemoTools
Other
61 stars 31 forks source link

Mismatch in AgeInt docs in lt_abridged #112

Open cimentadaj opened 4 years ago

cimentadaj commented 4 years ago

The default value for AgeInt in lt_abridged is age2int(Age = Age, OAvalue = 5) but in the docs it says AgeInt: integer. Vector of age class widths. Default ‘inferAgeIntAbr(Age = Age)’.

cimentadaj commented 4 years ago

But now that I think of it, (1) wouldn't it be better to calculate AgeInt internally without the argument? I mean, Age is necessary and whatever AgeInt they want to input can be obtained from Age. The only difference is whether it's an open ended age group and that can be specified through OAG.

(2) In any case, what do you think of setting AgeInt to NULL and internally checking with the supplied AgeInt is NA and proceed to calculating it with age2int.

timriffe commented 4 years ago

Seems reasonable, will add to forthcoming changes. Age always implies AgeInt (except OAG), but not the other way around.

On Fri, Jan 3, 2020 at 11:19 AM Jorge Cimentada notifications@github.com wrote:

But now that I think of it, (1) wouldn't it be better to calculate AgeInt internally without the argument? I mean, Age is necessary and whatever AgeInt they want to input can be obtained from Age. The only difference is whether it's an open ended age group and that can be specified through OAG.

(2) In any case, what do you think of setting AgeInt to NULL and internally checking with the supplied AgeInt is NA and proceed to calculating it with age2int.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/timriffe/DemoTools/issues/112?email_source=notifications&email_token=AAG43GZDSAEHPNPFCVFRYX3Q34GL7A5CNFSM4KCLTJQKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIAZRFA#issuecomment-570529940, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAG43G53CNT2K32KSVMHKELQ34GL7ANCNFSM4KCLTJQA .