Closed cimentadaj closed 3 years ago
will have a look, thanks!
Commenting here, I know not ideal, but:
-[ ] let's not hard code the returned age-range in mig_beta()
. The required range can be detected from mat_resid$age
or similar
-[ ] add max age arg for child adjust? requires look at mig_beta_cwr()
currently I think only cohorts born between censuses get the adjustment? Maybe that's an OK default, but would be nice to allow the user to declare a max age to override it. You can pass on this one if it's a pain now.
There may be other things, but these are just things I noticed by eyeballing and no need to rush at this point. I'll pass this to road test
Hi all,
I am noticing several things:
See my revised comparison code and other files in Google drive folder *WPP_Methods
Tools > Templates > ResidualMigBeta*.
Here are the graphs: [image: image.png] [image: image.png] Let me know if you have any questions, pj
On Sun, Apr 18, 2021 at 4:14 PM Tim Riffe @.***> wrote:
Commenting here, I know not ideal, but: [ ] let's not hard code the returned age-range in mig_beta(). The required range can be detected from mat_resid$age or similar [ ] add max age arg for child adjust? requires look at mig_beta_cwr()currently I think only cohorts born between censuses get the adjustment? Maybe that's an OK default, but would be nice to allow the user to declare a max age to override it. You can pass on this one if it's a pain now.
There may be other things, but these are just things I noticed by eyeballing and no need to rush at this point. I'll pass this to road test
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/timriffe/DemoTools/pull/234#issuecomment-822053798, or unsubscribe https://github.com/notifications/unsubscribe-auth/APAK5QRENUPEMZ2WERYLSM3TJM4SRANCNFSM43ERZOGQ .
Summary:
Child adjust:
Old age adjustment:
Let me know if you need me to change stuff. I'll commit here as needed.