search

timriffe / ODAPbackend

Other
0 stars 2 forks source link

Additional smoothing errors #30

Open cimentadaj opened 6 days ago

cimentadaj commented 6 days ago

Hi @TTRustam,

Similar to #29, here's another error:

res <-
  readr::read_csv("~/Downloads/abridged_data.csv") %>%
  ODAPbackend:::create_groupid(c("Sex", "Province"))

smooth_result <- smooth_flexible(
    res,
    variable = "Deaths",
    rough_method = "none",
    fine_method = "none",
    constrain_infants = TRUE,
    age_out = "abridged"
  )
## $data
## # A tibble: 0 × 0

## $figures
## $figures$`4`
## NULL

## $figures$`2`
## NULL

## $figures$`3`
## NULL

## $figures$`1`
## NULL

Is this expected?

cimentadaj commented 6 days ago

@TTRustam to proactively avoid this after your fixes, can you check running smooth_flexible with all possible combination of arguments and check the results don't throw errors, they make sense (cc #31) and are not empty?

TTRustam commented 6 days ago

Hola Jorge,

Thank you for noticing this. In this particular case, I forgot to add a corresponding output to one of the return() functions, so this is an easy fix. However, you are absolutely right. I need to test the function with all possible inputs and arguments. I will be on it and will make all corresponding changes ASAP. Sorry for the confusion.

Best regards, Rustam.

вс, 13 окт. 2024 г. в 12:50, Jorge Cimentada @.***>:

@TTRustam https://github.com/TTRustam to proactively avoid this after your fixes, can you check running smooth_flexible with all possible combination of arguments and check the results don't throw errors, they make sense (cc #31 https://github.com/timriffe/ODAPbackend/issues/31) and are not empty?

— Reply to this email directly, view it on GitHub https://github.com/timriffe/ODAPbackend/issues/30#issuecomment-2408928128, or unsubscribe https://github.com/notifications/unsubscribe-auth/AF3HFBVFMXZKXLXU5EVOUC3Z3JF6FAVCNFSM6AAAAABP3KARM6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMBYHEZDQMJSHA . You are receiving this because you were mentioned.Message ID: @.***>