search

timriffe / TR1

Read Human Mortality Database and Human Fertility Database Data from the Web
10 stars 4 forks source link

getHFDdate rewrite #1

Closed stephenholzman closed 8 years ago

stephenholzman commented 8 years ago

Found readHFDweb to be broken unless providing a manual Update argument. Traced issue to getHFDdate function, rewrote to fix bug. Not sure if it was humanfertility.org website update or some global setting on my machine that changed, but this is an alternative method of grabbing the date string.

timriffe commented 8 years ago

Thanks Stephen, it works nice n quick. Likely the HFD will redo their web design at some point, which will break everything, so I'll just have to keep pace. I've asked them to provide a csv of metadata like HMD so that it's easier to make requests without having to infer metainfo with separate requests. will see if they do that.

stephenholzman commented 8 years ago

No problem. Friendly metadata definitely seems like the ideal solution. Happy to help debug future issues if they come up though.