search

timriffe / TR1

Read Human Mortality Database and Human Fertility Database Data from the Web
10 stars 4 forks source link

Fixed an error in `getHFDitemavail` #23

Closed samhyunyoo closed 1 year ago

samhyunyoo commented 1 year ago

Hi Tim,

Recently while trying to import data from the HFD web using readHFDweb, I encountered an error. After some investigation, I discovered that certain parity-specific data columns were in numeric format, causing an issue with collecting column names in getHFDitemavail. To revolve this issue, I made a small modification in HFDutils.R by adding a line of code to convert all numeric columns to character format. I think that this should address the issue. Thank you.

timriffe commented 1 year ago

Hi Sam! Thanks so much, nice find. I had recently become aware of this but didn't find the time to look into it. I ended up replacing you suggestion of mutate_if() with the mutate(across(where()) because it seems mutate_if() probably will be deprecated one day. I really appreciate the PR! I've added you to the DESCRIPTION file in the ctb role if this is OK

samhyunyoo commented 1 year ago

Hi Tim,

I am glad it helps. Thank you.

Sam Hyun Yoo, Ph.D.

Associate Professor & Department Chair

Department of Sociology

Hanyang University

Seoul 04763, South Korea

2023년 7월 25일 (화) 오후 11:17, Tim Riffe @.***>님이 작성:

Hi Sam! Thanks so much, nice find. I had recently become aware of this but didn't find the time to look into it. I ended up replacing you suggestion of mutate_if() with the mutate(across(where()) because it seems mutate_if() probably will be deprecated one day. I really appreciate the PR! I've added you to the DESCRIPTION file in the ctb role if this is OK

— Reply to this email directly, view it on GitHub https://github.com/timriffe/TR1/pull/23#issuecomment-1649932577, or unsubscribe https://github.com/notifications/unsubscribe-auth/AI3JOUDVTEDPTXHU5EO7DZ3XR7IORANCNFSM6AAAAAA2XB26YE . You are receiving this because you authored the thread.Message ID: @.***>