search

timroesner / WeMart

🛒 Online grocery shopping portal. Created as part of the course CmpE 133 during spring 2018.
https://wemart-133.herokuapp.com
GNU General Public License v3.0
19 stars 10 forks source link

Icon font is displayed as emojis on mobile #34

Closed timroesner closed 6 years ago

timroesner commented 6 years ago

Here is a screenshot:

img_1e404d4591e8-1

timroesner commented 6 years ago

Check out this suggestion: https://github.com/instacart/Snacks/issues/120

Sent with GitHawk

juancstlm commented 6 years ago

Nice, ill make a branch and test the fix

juancstlm commented 6 years ago

image image image

any idea why even after giving it a path to get the fonts it throws out that error?

timroesner commented 6 years ago

No clue. We might be better off using font awesome then

juancstlm commented 6 years ago

Looks like it. What a shame I really liked their icons.

rajmakda commented 6 years ago

I switched the counter component icons to font awesome ones as well. We could later on try to download the SVG file and test the icons from snacks if that is possible and if time permits.

juancstlm commented 6 years ago

I found a hella janky workaround for this

<SetStyles assetsUrl={'https://instacart.github.io/Snacks/src/fonts'} />