Closed timroesner closed 6 years ago
The on sale badge also seems to be affected
@timroesner What is the widest we realistically need the item card to be? No more than 160?
So since we only have four items right now the button is quite large. This is how it looks with four items, button width is at 216px:
Closing. Issue fixed in 2e6da5b
Just to double check 16rem is 256px right?
the way I understood it was that 16rem with some css trickery was 160px.
So if the root html element is set to
html {
font-size: 62.5%;
}
then rem of n is actually 10x n
but without that it would be 256px instead of 160px
As expected the button should shrink with the ItemCard component, however it should not exceed the maximum width of the cell. Here is a picture to clarify: