Bugfix #173 - Guard against possible falsy node.children values

timruffles / mobile-drag-drop

A drop-in shim to allow you to use existing html5 drag'n'drop code with mobile browsers

http://timruffles.github.io/mobile-drag-drop/demo/

MIT License

603 stars 150 forks source link

Bugfix #173 - Guard against possible falsy node.children values #174

Closed johanquiroga closed 1 year ago

johanquiroga commented 1 year ago

The purpose of this PR is to add a check against undefined values when checking for node children within the removePointerEventsFromShadoDomChildNodes function.

Unfortunately, I don't have a way of reproducing this yet, but I tracked down the error mentioned in #173 to this. Using this patch fixes the issue for me.

This should fix #173.

reppners commented 1 year ago

Thanks for your contribution!

johanquiroga commented 1 year ago

@reppners Thank you for merging this in! Just curious, when do you think this could be released?

reppners commented 1 year ago

@johanquiroga Published now as 3.0.0-rc.0 :) Ride safe! 🏍️