search

timsainb / tensorflow2-generative-models

Implementations of a number of generative models in Tensorflow 2. GAN, VAE, Seq2Seq, VAEGAN, GAIA, Spectrogram Inversion. Everything is self contained in a jupyter notebook for easy export to colab.
996 stars 187 forks source link

incorrect discriminator loss in GAIA notebook #12

Open hanshengchiu opened 4 years ago

hanshengchiu commented 4 years ago

The following is discriminator's loss in the GAIA notebook. Shouldn't the d_xg_loss be negative? disc_loss = d_xg_loss + d_x_loss - tf.clip_by_value(d_xi_loss, 0, d_x_loss)

Abel1802 commented 3 years ago

I encountered the same problem when I reproduced the code.

timsainb commented 3 years ago

I should have mentioned that the notebook there was me experimenting with a variation of GAIA that I was trying out. I just added a line in the readme saying as much. But you're right. If someone wants to make a PR with the original algorithm for GAIA it would be much appreciated.

Abel1802 commented 3 years ago

I should have mentioned that the notebook there was me experimenting with a variation of GAIA that I was trying out. I just added a line in the readme saying as much. But you're right. If someone wants to make a PR with the original algorithm for GAIA it would be much appreciated.

Thank you!

timsainb commented 3 years ago

I've got a cleaner tensorflow 1 implementation of GAIA in a private repo that I used for the 2D meshplot examples figure from the paper BTW. If anyone wants that code / access to that repo just ask. The repo is private just because its full of _Copy3.ipynb files with additional experiments that I never got around to making presentable.