search

timschlechter / SpecResults

Get better feedback from your SpecFlow testsuite
http://specflowreporting.azurewebsites.net/
MIT License
23 stars 18 forks source link

Added multiline parameter support and added table and multiline parameter printing in the plain text formatter #10

Open Stewartarmbrecht opened 10 years ago

Stewartarmbrecht commented 10 years ago

Added support for multiline parameters. Also added support for printing table and multiline parameters to the plain text formatter. Improved the step.Title builder to use regular expressions instead of expecting "(.*)" for all parameters. The plain text formatter could use some optimization.

I accidentally reformatted the Step class to use 2 spaces for indentation. You can reformat this back to 4 spaces. The only thing I changed in this class was add the MultilineParameter property.

Also, you'll probably want to optimize the GetMaxColumnCharaters to use a cache instead of iterating over every value for the column each time you call it.

Stewartarmbrecht commented 10 years ago

Not sure why the AppVeyor build failed. The error message is vague. It looks like the Beyond Comparison step failed. "It ran fine for me locally" ;) Is there something I am missing in the way this build works?

Stewartarmbrecht commented 10 years ago

Actually this looks like more to do with installing Beyond Compare: Unhandled Exception: System.Exception: Could not find BeyondCompare at C:\Program Files\Beyond Compare 3\BCompare.exe, please install it

Stewartarmbrecht commented 10 years ago

Maybe we can replace Beyond Compare with something that installs via NuGet packages?

timschlechter commented 10 years ago

Hi Stewart, Sorry for my late reaction, I hadn't found the time to handle this PR. Very nice change, this fixed a nasty bug.

I had to make some modifications to make the build run well, this PR landed in c6f12134b4

The reason the build kept failing was because of the test which explicitly throws an execption. I removed this testcase because it caused some more problems. I will cover this case by an unit test instead of an approval test.

Totally agree on replacing the Beyond Compare reporter, will do so.