search

timschneeb / RootlessJamesDSP

An implementation of the system-wide JamesDSP audio processing engine for non-rooted Android devices
GNU General Public License v3.0
919 stars 28 forks source link

Using with YouTube Revanced ... #122

Closed iplayradionetworks closed 1 year ago

iplayradionetworks commented 1 year ago

I see that it works fine with YouTube Revanced but I spotted that it doesn't respect the muted audio on auto play videos .

Not a big deal but I thought I could mention it here.

Surely it's not a sort of bug.

Regards Jim

timschneeb commented 1 year ago

YouTube appears to open an audio session for muted auto-play videos; however, that is an expected design decision by the developers.

RootlessJamesDSP will automatically intercept any supported app that opens a new audio session, and there's no way for me to know whether an app is actually playing music before intercepting its audio output. Because of that, it needs to keep an eye on all active audio sessions, even if they aren't currently used for any playback.

iplayradionetworks commented 1 year ago

Ok thank you.

It makes absolutely sense . In the case of the audio being muted via YouTube (Revanced or not) during auto play on main screen (without actually selecting the video to play) it's not actually muting the audio pipeline... The audio keeps playing in background but not heard unless you click a button to unmute.

Thanks again .