timschneeb / RootlessJamesDSP

An implementation of the system-wide JamesDSP audio processing engine for non-rooted Android devices
GNU General Public License v3.0
914 stars 28 forks source link

[Feature Request] Volume Normalizer #141

Closed SunBreaker1 closed 1 year ago

SunBreaker1 commented 1 year ago

With all the sound controls and effects, an option to normalize the playback volume would be a good complement to the already available options.

Personally, I'm an offline user, meaning I have music downloaded and use apps that control DSP and my library. The biggest problem with this is that every album has a different LUFS mastering level, meaning one song will be giod while the next will be loud and could cause hearing problems.

Adding a LUFS (industry standard) based normalizer could make sure that all played back songs/audio is at the same level without any explosive volume levels to damage hearing.

ghost commented 1 year ago

have you tried to use replaygain in your player?

SunBreaker1 commented 1 year ago

have you tried to use replaygain in your player?

Symphony does not have that option

ghost commented 1 year ago

well, I recommend you use other player like poweramp or aimp. or you can suggest the symphony developer to add replaygain to this player, I think it's not hard. I don't think, that James dsp will be able to do normalization by tracks and albums because it's real-time dsp. you need to analyze each song to know how loud it is. James DSP can't do that.

SunBreaker1 commented 1 year ago

well, I recommend you use other player like poweramp or aimp. or you can suggest the symphony developer to add replaygain to this player, I think it's not hard. I don't think, that James dsp will be able to do normalization by tracks and albums because it's real-time dsp. you need to analyze each song to know how loud it is. James DSP can't do that.

From my brief testing, the implementation of Replaygain in aimp is inconsistent.

The main song I used; Bully - Calliope Mori and Replaygain 5db. The first few seconds of the song were unchanged and a little loud, then it slowly started to get quieter as the song progressed stabilizing at a lower volume.

Tldr; starts loud then gets quieter

I then tried with Replaygain off, and the volume stayed consistent throughout the song. Same thing happens with Boof Pack - Lord Aethelstan

Yeah, it sounds like a "first world me problem", but that's what happens when songs and albums aren't mastered to the same volume, and I really want to try and avoid progressing my tinnitus even more with sudden loud bursts

SunBreaker1 commented 1 year ago

well, I recommend you use other player like poweramp or aimp. or you can suggest the symphony developer to add replaygain to this player, I think it's not hard. I don't think, that James dsp will be able to do normalization by tracks and albums because it's real-time dsp. you need to analyze each song to know how loud it is. James DSP can't do that.

Have you heard of TarsosDSP?

timschneeb commented 1 year ago

I'm only the developer of the rootless implementation; this repo only contains that.

The actual DSP algorithms are maintained by James in a different repository: james34602/JamesDSPManager. If you'd like to request new effects, please open an issue there instead. (Or alternatively, leave a message in the Telegram group https://t.me/jDSP_V4A; you might get a faster response there)