search

timschofield / webERP

webERP Accounting and Business Administration ERP system
https://www.weberp.org
GNU General Public License v2.0
29 stars 113 forks source link

[Upgrade to PHP8.3] IDE-assisted Debugging - casual code scanning - part 1 #190

Closed aingelc12ell closed 1 month ago

aingelc12ell commented 1 month ago

Fix: Curly brace access syntax as deprecated since PHP 7.4 Fix: Transform each() to foreach() as removed in PHP8.0 Fix: [] operator on strings Fix: Variables to be passed by reference Fix: Left and right hand sides of the assignment operator are equal Fix: Undefined API Error constants and descriptions Fix: DB_error_no called as string Fix: String constants as functions Fix: String constants as quoted strings Fix: Misplaced break on switch statement Fix: construct to construct() Fix: Misspelled Ivalid... to Invalid...

timschofield commented 1 month ago

Thanks Aingel, just the one comment on all those:

In SuppPriceList.php you are correct to identify the ENT_QUTOES as an error, but it is meant to be the built in constant ENT_QUOTES so shouldn't need quote marks.

Other than that it's all great

Tim