Warning: Undefined array key "action" in /weberp/reportwriter/admin/ReportCreator.php on line 54

[pakricard]

Report creator shows a warning on v 4.15.2 and also latest GitHub code with PHP 8:

Warning: Undefined array key "action" in /weberp/reportwriter/admin/ReportCreator.php on line 54

[timschofield]

The report writer was an area I was never really involved in, even back in the day.

There appears to be a lot of issues with it, I think it needs a big rewrite.

Thanks Tim

On Wed, 20 Nov 2024 at 06:02, pakricard @.***> wrote:

Report creator shows a warning on v 4.15.2 and also latest GitHub code with PHP 8:

Warning: Undefined array key "action" in /weberp/reportwriter/admin/ReportCreator.php on line 54

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you are subscribed to this thread.Message ID: @.***>

-- www.weberp.org @TimSchofield2 Blog: https://kwamoja.home.blog/

[pakricard]

I am not using it at all, probably in the past 10 years, as the reporting capabilities are very limited. If we haven't received many bugs from users or other developers, most likely is because it isn't used. Should we get rid of it for v5?

[dalers]

What problem was ReportCreator intended to solve? Was it a good solution? If ReportCreator is removed, how can the same goal be achieved?

I'm 100% in favor of removing code that doesn't provide useful functionality or where the same goal could be accomplished better with a separate app, especially if the code doesn't work and is difficult to fix and maintain. I just don't know enough about ReportCreator to have an opinion.

[pakricard]

ReportCreator creates simple user-generated reports. By “simple” I mean "really simple".

To me, it was not a suitable solution and ended up creating custom PDF reports every time we needed something not available in webERP, as this ReportCreator has plenty of limitations.

I am not using it, just reported the warning message as I am cleaning and checking my weberp.

If we have not received errors or complaints in the past 10 years, to me, is a strong indication that virtually no one is using it. But if we vote to keep it, it should be without warnings or errors as next PHP update most probably it will stop working,

[timschofield]

The code never followed the webERP "principles" and I'm not sure if anybody actually used it in many years.

Personally I would remove it and see if anybody shouts.

Thanks Tim

On Mon, 25 Nov 2024 at 08:07, pakricard @.***> wrote:

ReportCreator creates simple user-generated reports. By “simple” I mean "really simple".

To me, it was not a suitable solution and ended up creating custom PDF reports every time we needed something not available in webERP, as this ReportCreator has plenty of limitations.

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you commented.Message ID: @.***>

-- www.weberp.org @TimSchofield2 Blog: https://kwamoja.home.blog/

[pakricard]

Agree.

[dalers]

OK, I support @pakricard and @timschofield and agree ReportWriter should be removed. Does that mean the issue label needs to be updated? To what?

[andrewcouling]

May I suggest that we attempt gather some insight from users on the Report Creator before deciding to remove a feature that some might use routinely. This could be done with a simple Google Form (or similar) sent out to the mailing lists. I don't use the Report Creator myself , I'm not overly concerned about the outcome, but feel this should be an informed decision. Thoughts?

[dalers]

More information is always good, and it's not like there's a deadline for a decision. :-) Are you volunteering Andrew? ;-)

I propose we put a pause on taking any action until at least 2 weeks after Andrew emails the form to the mailing list. Those For? All Against?

In the meantime I'm going to at least read the ReportWriter section in the manual so I am better informed...

[andrewcouling]

Are you volunteering Andrew? ;-)

Yes, I'm happy to. I can draft a survey, and share a link here for review before publishing.

[dalers]

Fwiw, from the git log: On Dec 19, 2005 @PhilDaintree added "Dave's Form Maker" (likely Dave Premo), and it doesn't seem to have changed substantially since except @pakricard "Revised report writer with the ability for more fields" in 2010.

The rest of the commits look to be compatibility commits mostly by @timschofield @pakricard @PhilDaintree @TurboPT and largely ending ~2018, with a couple commits to the .inc files in the past couple months by Paul Thursby (aka TurboPT?), @aingelc12ell and @timschofield.

[timschofield]

Thanks Dale/Andrew that's a great solution.

Tim

On Tue, 26 Nov 2024 at 20:47, Dale Scott @.***> wrote:

Fwiw, from the log: On Dec 19, 2005 @PhilDaintree https://github.com/PhilDaintree added "Dave's Form Maker" (likely Dave Premo), which hasn't changed substantially since except @pakricard https://github.com/pakricard "Revised report writer with the ability for more fields" in 2010.

The rest of the commits look to be compatibility commits mostly by @timschofield https://github.com/timschofield @pakricard https://github.com/pakricard @PhilDaintree https://github.com/PhilDaintree @TurboPT https://github.com/TurboPT and largely ending ~2018, with a couple commits to the .inc files in the past couple months by Paul Thursby, @aingelc12ell https://github.com/aingelc12ell and @timschofield https://github.com/timschofield.

— Reply to this email directly, view it on GitHub https://github.com/timschofield/webERP/issues/247#issuecomment-2501904749, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAL6LD53RUFAEDTM3LPSRT2CTM5PAVCNFSM6AAAAABSDYGWQWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMBRHEYDINZUHE . You are receiving this because you were mentioned.Message ID: @.***>

-- www.weberp.org http://www.weberpafrica.com @TimSchofield2 Blog: https://kwamoja.home.blog/