Transform resource URL to include size

timse / srcset-loader

Flexible srcset-loader for webpack

46 stars 14 forks source link

Transform resource URL to include size #12

Closed PaulKiddle closed 7 years ago

PaulKiddle commented 7 years ago

Quick go at a fix for #11 .

Adds new loader option transformResource for generating a unique resource URL for each resized image request. Generates unique keys in webpack manifest. Defaults to generating e.g. filename.jpg?size=300w.

I'm not in a huge rush for a merge so happy to do a bit of bikeshedding on variable names etc.

PaulKiddle commented 7 years ago

Reverted those changes

timse commented 7 years ago

sorry for the late reply!

Ha interesting with the changes and the tests in that case i guess they could have just stayed in, sorry for the hazzle, will merge this for now anyways. happy for another pr with the addEventlisteners

timse commented 7 years ago

published as 2.1.0