search

timse / srcset-loader

Flexible srcset-loader for webpack
46 stars 14 forks source link

Ratio fixes #16

Closed tremby closed 6 years ago

tremby commented 6 years ago

See #14 and #15

The final commit in this set is potentially a breaking change for anyone relying on placeholder.ratio for any calculations. The migration for such code is to use 1/placeholder.ratio in place of placeholder.ratio.

The added test image is CC-0, from https://pixabay.com/en/glastonbury-tor-great-britain-232358/

tremby commented 6 years ago

Note that while testing I commented out the ?placeholder=[width]: accepts the placeholder size as value test, since that one times out and fails for me (even before I made any modifications).

timse commented 6 years ago

thanks for the pr! and sorry for the late reply - will merge :)