timsueberkrueb / webber

Making webapps superfluous since 2019
https://open-store.io/app/webber.timsueberkrueb
Other
14 stars 9 forks source link

Lack of Strips with various options of a website #27

Closed gbdomubpkm closed 4 years ago

gbdomubpkm commented 4 years ago

In some webapps, unlike web pages of some websites, there is not the strip that contains various options. See here for the Equipe site, but this is also the case for banking or telecommunication sites ...

WEBEQUIPE20200407 website

WEBAPPEQUIPE20200407 webapp without the strip

In your opinion, is there a particular request possible to make in Morph concerning the webapp-container ? As it doen't concern webber app directly i think.. Thank you in advance for your advice.

timsueberkrueb commented 4 years ago

This only happens for me with L'Équipe if I enable the option to show a title bar in Webber. This behavior is controlled by webapp-container and apparently occurs when the --enable-addressbar flag is set.

I'm pretty sure that this is a bug in webapp-container. I have the suspicion that there is a QML layouting issue in webapp-container because it looks like part of the menu at the bottom is shown, which could indicate that the webview's height actually goes beyond the visible area. This theory is supported by other examples where only part of the footer and the vertical scrollbar is visible if one scrolls to the very bottom of a page.

I think we should open an issue at ubports/morph-browser.

gbdomubpkm commented 4 years ago

You're absolutely right. For 'L'Équipe', creating a webapp using the 'Show title bar with previous/next buttons' option and then zooming the webapp to 200% will bring up the options strip. The 'Don't show title bar' option, if it's enough to make this option strip appear for the l'Équipe webapp, is not enough to make this strip appear for a webapp created with my bank, but the problem is most certainly identified.

gbdomubpkm commented 4 years ago

Done new issue opened for morph-browser

gbdomubpkm commented 4 years ago

Fixed. By this https://github.com/timsueberkrueb/webber/issues/20 as been fixed too! Good for the webapps !