search

timsueberkrueb / webber

Making webapps superfluous since 2019
https://open-store.io/app/webber.timsueberkrueb
Other
14 stars 9 forks source link

Improve icon finder #37

Closed bhdouglass closed 3 years ago

bhdouglass commented 4 years ago

It appears as if it's just the favicon that is being parsed for use as the app's image. Is there any way the web manifest or other icons (opengraph/apple) could be parse for a better option (If it's not doing that already)?

timsueberkrueb commented 4 years ago

Hey Brian, it's currently looking for the following patterns: https://github.com/timsueberkrueb/webber/blob/master/src/core.rs#L52 Supporting the PWA manifest would be a great enhancement, though.

bhdouglass commented 4 years ago

Ok, cool, so is it using the apple icon or favicon first?

timsueberkrueb commented 4 years ago

It's currently using the favicon first, which is probably a mistake. It also ignores the sizes attribute. There is definitely some room for improvement here :)

bhdouglass commented 4 years ago

Ok, so I'm thinking maybe check if there is a manifest and parse that first for info. If no manifest, then check for and find the best apple icon, falling back to the opengraph icon, and finally using the favicon. What do you think?

timsueberkrueb commented 4 years ago

Sounds good :+1:

timsueberkrueb commented 3 years ago

This is now finally in progress. Initial PWA support has been implemented.

TODO:

timsueberkrueb commented 3 years ago

Done.