search

timsutton / aamporter

Utility to batch download Adobe Creative Suite/Cloud updates and optionally import them into a Munki repository.
MIT License
86 stars 14 forks source link

Optionally use makepkginfo instead of munkiimport #1

Closed jamesez closed 11 years ago

jamesez commented 11 years ago

Wat it says on the tin.

timsutton commented 11 years ago

Looks good, thanks!

One question, is there any particular reason you want to skip the --force-import option if munki_tool is set to makepkginfo? I realize your use case isn't common, and that it will just overwrite the same pkginfo again anyway, but I'm thinking it would make more sense if --force-import worked the same way regardless of the munki_tool choice, and it just didn't run the import tool at all (unless you force).

jamesez commented 11 years ago

I'd have to re-implement the logic from the munkiimport library that finds the old package, and that seems like a serious amount of work for not that much upside, since I was expecting that anyone who was going to use makepkginfo was going to manually add the packages to the master repo later.

timsutton commented 11 years ago

Oh, that's true. I was only testing the scenario when it is still being reachable using munkiimport (and thus just calling functions defined in munkiimport).