chef, puppet: disable install if version="none"

timsutton / osx-vm-templates

macOS templates for Packer and VeeWee.

MIT License

1.12k stars 248 forks source link

chef, puppet: disable install if version="none" #62

Closed amosshapira closed 8 years ago

amosshapira commented 8 years ago

Make it possible to skip chef install (but keep other CM's) by specifying version="none"

timsutton commented 8 years ago

Hm, I'm thinking maybe supporting none makes sense for both Chef and Puppet (and any other tool we could possibly add later). @bacongravy just added a nocm variable to disable both, but I'm wondering if it's simpler to just support one method and expect version=none to be the only way to disable any add-on tool like this.

I'm also not really opposed to the idea of just making these default to none, and then those who want them can set them to latest or a specific version.

amosshapira commented 8 years ago

I agree, I was just offering the smallest change as a starting point. I'll add it to the other CM's.

bacongravy commented 8 years ago

I just put together a change that backs out the original nocm=true approach and allows each tool version to be set to none to skip the install, and makes none the default. I've also updated the README. I'll create the pull request just as soon as I test the changes.