timum-viw / socket.io-client

A socket.io-client implementation for ESP8266 and Arduino
228 stars 90 forks source link

Disabling Serial Debug #46

Closed florian-guillemard closed 5 years ago

florian-guillemard commented 5 years ago

Hi,

I would like to disable serial debug on compilation with a flag like NODEBUG_SOCKETIOCLIENT

Is it possible to change this :

#define SOCKETIOCLIENT_DEBUG(...) Serial.printf(__VA_ARGS__);
//#define SOCKETIOCLIENT_DEBUG(...)

By :

#ifndef NODEBUG_SOCKETIOCLIENT
   #define SOCKETIOCLIENT_DEBUG(...) Serial.printf(__VA_ARGS__);
#else
   #define SOCKETIOCLIENT_DEBUG(...)
#endif

Thanks,

timum-viw commented 5 years ago

sure, sounds reasonable. Would you mind making a pullrequest or shoud I just commit it for you? cheers!

florian-guillemard commented 5 years ago

Hi,

Could you commit it for me, please ?

Thanks,

timum-viw commented 5 years ago

done!