search

timusus / RecyclerView-FastScroll

A simple FastScroller for Android's RecyclerView
Other
1.39k stars 182 forks source link

Scrolling whlie dragging the thumb isn't continuous #103

Closed zhanghai closed 4 years ago

zhanghai commented 5 years ago

On the contrary, it jumps with small increments.

In v1.0.18 the scrolling while dragging is still continuous and beautiful.

I suspect #83 is causing this regression, as it makes the recycler view skip scrolling until the accumulated drag distance exceeds touch slop. Touch slop is most often used for distinguishing a click from drag, but not for the process within dragging itself, so I don't think it should be the intended behavior.

goldy1992 commented 5 years ago

Removing the mTouchSlop comparison removes the problem for dragging as you correctly predicted @zhanghai .

However, when running the sample app, the scroll bar for normal scrolling still seems to be jumping in small increments; this I believe is due to the amount of time spent in the main thread, as the image is not cached

goldy1992 commented 5 years ago

@zhanghai @timusus please see the pull request for issue 103