timusus / RecyclerView-FastScroll

A simple FastScroller for Android's RecyclerView
Other
1.39k stars 182 forks source link

Issue-103 - reverted the mTouchSlop checks as they are not needed for… #105

Closed goldy1992 closed 4 years ago

goldy1992 commented 5 years ago

Fix made for Issue 103.

As suggested by @zhanghai mTouchSlop is not needed for scroll gestures in dragging, and actually degrades the smoothness of the scrolling

timusus commented 4 years ago

The touch slop here just ensures that the suer actully moved their finger more than a certain amount in the vertical direction, before we update the position of the thumb. So if the user just rests their finger, but barely moves it, we don't immediately start scrolling.

I checked out this commit, but it didn't seem to solve the scrolling smoothness issue. Either way, I've implemented a fix for that now. Let me know if you still think it's necessary to remove the touch slop check.