timusus / RecyclerView-FastScroll

A simple FastScroller for Android's RecyclerView
Other
1.39k stars 183 forks source link

Fix #18 ItemDecoration is drawn over FastScrollPopup #19

Closed Nammari closed 8 years ago

timusus commented 8 years ago

Thanks for your contributions.

There are quite a few changes here which don't relate to #18. The changes to the animation performance add quite a lot of code for the sole benefit of premature optimisation. As discussed via email, these changes aren't to fix any measured lag - they're just pre-emptive. Given the level of complexity they add to the library, and no measured benefit, I'd prefer to leave them out.

I haven't been able to confirm that the fix to #7 is a general fix, or whether it just fixed the issue in the specific sample provided. I'd like to do some more investigation before accepting that as a fix. When digging around the code, it did not look particularly solid.

I've started merging the changes for 'set popup typeface' and I'll merge the 'enable/disable' indicator stuff soon. But, I'd prefer not to accept this pull request for the reasons stated above.