search

timusus / RecyclerView-FastScroll

A simple FastScroller for Android's RecyclerView
Other
1.39k stars 183 forks source link

Change width of scroll thumb #33

Closed Frechetta closed 6 years ago

Frechetta commented 8 years ago

The width of the scroll thumb should be changeable. The FastScroll thumb is about twice the width of the original one.

behelit commented 7 years ago

It's the same as the google app drawer fastscroll thumb thickness, which I like, but it should be changeable.

MuhamedFathy commented 7 years ago

The same here, It's wide more than normal.

G00fY2 commented 7 years ago

Atm this FastScroll implementation is pixelperfect to what Google is using in it's contact app. Can upload an screenshot later as a proof.

timusus commented 7 years ago

@G00fY2 this library isn't aiming to match Google's latest implementation exactly. It wouldn't hurt to add a property to set the width. Still, I'm not planning on making this change myself any time soon.

G00fY2 commented 7 years ago

My intention was not to question the option to make the width changeable. I also think that this would be a very useful feature. I was just responding to the statements that it's wider or even twice as width as "the original". :)

If you don't mind I will see if I can create another PR.

timusus commented 7 years ago

Yeah, no worries. I just don't want anyone getting disheartened that we won't implement this feature because it already matches Google's designs.

Please go ahead with a PR, and thanks for your work.

timusus commented 6 years ago

Closing due to inactivity.