timusus / RecyclerView-FastScroll

A simple FastScroller for Android's RecyclerView
Other
1.39k stars 183 forks source link

Scroll thumbnail is not hiding in release builds with obfuscation #39

Closed ikravchenko closed 7 years ago

ikravchenko commented 7 years ago

I am currently adding the following proguard config to fix it:

# ---- FastScrollRecycleView ----
-keep class com.simplecityapps.recyclerview_fastscroll.** { *; }
# ---- END FastScrollRecycleView ----

Please add a note or include progurd rules into your lib.

iAlex97 commented 7 years ago

By trial end error I found out that you only need to keep FastScrollPopup (it cuts down a few methods) therefore the ProGuard config that I am using is the following:

# ------- FastScrollRecycleView START -------
-keep class com.simplecityapps.recyclerview_fastscroll.views.FastScrollPopup { *; }
# ------- FastScrollRecycleView END -------
timusus commented 7 years ago

Thanks for the info.

I just haven't gotten around to testing this out, which is why I haven't added a proguard rule to the library yet.

by-syk commented 7 years ago

I met this issue too and solved it by adding the Proguard rule. Thanks.

VladimirWrites commented 7 years ago

Works for me also. It should be added to README.md, and this issue should be closed.