search

timusus / RecyclerView-FastScroll

A simple FastScroller for Android's RecyclerView
Other
1.39k stars 183 forks source link

Add support for StaggeredGridLayoutManager #50

Closed rubengees closed 7 years ago

rubengees commented 7 years ago

This would add support for the StaggeredGridLayoutManager and fix #46.

Code changes

All calls to LayoutManagers were adjusted to also take the StaggeredGridLayoutManager in account, if necessary.

timusus commented 7 years ago

@rubengees howcome this one is closed?

rubengees commented 7 years ago

I thought it was obsolete as it did not get reviewed for quite some time. I can submit a new PR if you like (Already deleted the fork so i can't reopen).

timusus commented 7 years ago

Sorry, I should have reviewed this or at least mentioned why I haven't merged the changes.

It would be great if you could add an example of a working StaggeredGridLayoutManager in the sample app, so myself and users of the library can see it in action.

Also, if you can add the relevant information to the Readme explaining how this is used and any limitations, that would be great.