timusus / RecyclerView-FastScroll

A simple FastScroller for Android's RecyclerView
Other
1.39k stars 182 forks source link

Fastscroller doesn't respect padding. #6

Closed kabouzeid closed 5 years ago

kabouzeid commented 8 years ago

This is important to make it work with a collapsing toolbar for example. In this case the bottom padding changes when the toolbar collapses/expands. Because of that, currently a part of the fastscroller moves out of the screen when the toolbar is expanded.

Not really related to the CollapsingToolbarLayout, but a definite issue none the less. The FastScroll should respect the padding of its parent.

garretyoder commented 8 years ago

Couldn't we just have the fastscroller by padded based on the parent on layout? I'm about to integrate this into my own project so if the solution is as simple as such I'll submit a patch.

sagarvasnani commented 7 years ago

When can we expect a solution to this bug? This is really really needed.

timusus commented 6 years ago

I'm not sure what the use case for this is. Closing, as I don't think a change is necessary here.

@sagarvasnani feel free to reopen if you can demonstrate the issue you're having.