search

timusus / RecyclerView-FastScroll

A simple FastScroller for Android's RecyclerView
Other
1.39k stars 182 forks source link

Make xml field app:fastScrollPopupBackgroundSize accessible via Java code #70

Closed benjaminglatzeder closed 6 years ago

benjaminglatzeder commented 6 years ago

There are public methods like recyclerView.setPopupTextColor(); and recyclerView.setPopupTextSize(); but no method to set the popup background size

G00fY2 commented 6 years ago

The size of the popup background get calculated dynamically by measuring the actual text bounds of the shown text inside. By what criteria would you like to set a fixed size? This gets pretty hard when you can use numeric, all lower or all upper case characters.

You can see the logic in my pull request from #63.

benjaminglatzeder commented 6 years ago

After I changed the value of app:fastScrollPopupBackgroundSize a few times and compared the visual results, I realized that the default size is on point. Since I don't think my change request is necessary and I'm the OP I'll close this ticket.