New features - Githubissues

timusus / RecyclerView-FastScroll

A simple FastScroller for Android's RecyclerView

Other

1.39k stars 183 forks source link

New features #73

Closed jahirfiquitiva closed 6 years ago

jahirfiquitiva commented 6 years ago

Allow showing scrollbar from
Allow changing inactive thumb color
Rename setThumbInactiveColor method to enableThumbInactiveColor in order to make it more intuitive.
Rename setStateChangeListener to setOnFastScrollStateChangeListener in order to make it more intuitive.
Rename setThumbEnabled method to setFastScrollEnabled in order to make it more intuitive.
Update attributes. Set allowThumbInactiveColor to true by default
Update attribute in sample
Pass the item ViewHolder to MeasurableAdapter to ease the item height calculation

timusus commented 6 years ago

Thanks for these great contributions.

I've added a few comments, mostly just semantic things. Could you also update the readme to reflect these changes?

jahirfiquitiva commented 6 years ago

@timusus I have added the requested changes. Regarding the README update, should I add a new version to the list mentioning these changes? ... Probably version 1.0.18 ?

timusus commented 6 years ago

No that's ok, I'll do the versioning when I release it.

timusus commented 6 years ago

@jahirfiquitiva I'll merge this in, just waiting for that readme update, if you don't mind.

jahirfiquitiva commented 6 years ago

@timusus I just don't know what to change. There is nothing in the README mentioning the things that were changed

timusus commented 6 years ago

OK, no worries. I had assumed there would be some references to the method names or attributes which have changed, but it looks like they're not referenced in the readme,