search

timusus / Shuttle

Shuttle Music Player
Other
2.2k stars 480 forks source link

Pressing play on a folder grabs songs from similarly named folders #275

Open akanealw opened 6 years ago

akanealw commented 6 years ago

Shuttle version:

v2.0.3 beta 3

Device, OS:

Nexus 6 7.1.2 AICP ROM

Description of bug:

When selecting play on a folder, additional songs get added from similarly named folders.

Steps to reproduce:

  1. Folder wanted to play is named Tri-State
  2. Press 3 dots and then play on that folder
  3. Songs from folders named Tri-State (Remixes) and Tri-State Remixed are also added to the queue.

Expected outcome:

Only songs from originally selected folder should be played.

Observations/Actual Result:

If I run the same steps listed from Tri-State (Remixes) or Tri-State Remixed, only songs in those folders are played. It appears as if the play action grabs all songs from FolderName(wildcard) instead of just FolderName screenshot_20180118-202445

timusus commented 6 years ago

Thanks for reporting this bug.

Cause: Shuttle matches the path of the folder with paths of songs in the MediaStore, using a simple String.contains(). This should be a fairly trivial fix, see FileHelper#221 getSongList()