timusus / Shuttle

Shuttle Music Player
Other
2.2k stars 480 forks source link

Loop Button Doesn't Turn Off With Loop Off #510

Open TakuyaSama opened 4 years ago

TakuyaSama commented 4 years ago

Shuttle version:

2.0.17

Device, OS:

Xiaomi Mi 9T Pro, LineageOS 17.1 (AOSP 10)

Description of bug:

Loop button icon doesn't change correctly between Loop off and Loop all, it's impossible to differentiate them.

It should turn off when you're on Loop off.

Steps to reproduce:

  1. Launch Shuttle Music Player.
  2. Start to play a song.
  3. Go to the controls and tap on the loop button, as many times as you want to cycle the 3 possible states, to check that there's no visible way (apart of the toast message indicating which mode you are currently when you tap on the button), to know if you're on Loop off or Loop all.

Expected outcome:

The button icon should dim or turn off the light effect when the state is Loop off.

Observations/Actual Result:

The icon is visually the same as when you're on the state of Loop all.