search

timusus / Shuttle

Shuttle Music Player
Other
2.2k stars 480 forks source link

Albums of the same name are considered the same, even if they are from different years. #519

Open judilsteve opened 3 years ago

judilsteve commented 3 years ago

Shuttle version:

2.0.017

Device, OS:

Nokia 8.1, Android 10 (1 September 2020 security patch level)

Description of bug:

In the album view, if two albums have the same name they are grouped together. For example, Weezer have 6 self-titled albums which can be differentiated by year. American Football have three self-titled albums, which again can be differentiated by year. In both cases, the tracks from all these albums appear as one in the Album view. I suspect this might also happen for albums of the same name by different artists.

Steps to reproduce:

  1. Add at least two albums to your library that are tagged with the same album title (and same artist title?) but different years
  2. Open the album view

Expected outcome:

These albums should show as separate entries in the album list (maybe with the year in brackets and/or secondary text colour after the title).

Observations/Actual Result:

The two albums are shown as a single album, with the tracks interleaved.

--

I'm not familiar with this codebase, but could it be as simple as adding the artist and year fields to the hashCode() and equals() functions of the Album class in Album.java?