search

timvideos / HDMI2USB-fx2-firmware

HDMI2USB firmware for the Cypress FX2 found on the Digilent Atlys and Numato Opsis boards.
24 stars 11 forks source link

examples/lights: Add support for other boards #27

Closed paddatrapper closed 7 years ago

paddatrapper commented 7 years ago

Fixes #20

mithro commented 7 years ago

This change is generally looking okay. Any reason we can't merge it?

mithro commented 7 years ago

(IE What is WIP about it?)

paddatrapper commented 7 years ago

Only reason is because the common makefile changes how this is implemented slightly. So will update it once that is merged

On 9 Jul 2017, 23:58, at 23:58, Tim Ansell notifications@github.com wrote:

This change is generally looking okay. Any reason we can't merge it?

-- You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub: https://github.com/timvideos/HDMI2USB-fx2-firmware/pull/27#issuecomment-313968277

mithro commented 7 years ago

This should be merged now.

paddatrapper commented 7 years ago

Fixed and ready for merging

paddatrapper commented 7 years ago

All fixed

paddatrapper commented 7 years ago

It should probably be part of the fx2lib repo (https://github.com/mithro/fx2lib/pull/31), but the example should probably stay here, as people will be looking here for a way to test loading this firmware, not in fx2lib