search

timvideos / HDMI2USB-litex-firmware

A version of the HDMI2USB firmware based around LiteX tools produced by @Enjoy-Digital (based on misoc+migen created by @M-Labs)
https://hdmi2usb.tv
BSD 2-Clause "Simplified" License
145 stars 71 forks source link

Setting a custom modeline with incorrect syntax crashes the board #469

Open tdaede opened 5 years ago

tdaede commented 5 years ago 
H2U 00:00:05>m custom 
Parsing custom mode...
Failed to set custom mode - values out of range.
Aborted.

It shouldn't require resetting the board if a typo is made.

mithro commented 5 years ago

@tdaede Agreed that it shouldn't cause the system to lock up. Want to see if you can fix it?

The parsing code is at https://github.com/timvideos/HDMI2USB-litex-firmware/blob/585091ad3d6529f6f86c35a62a3b74ddd8a3df49/firmware/ci.c#L750-L875