search

timvideos / HDMI2USB-mode-switch

Tool for switching boards supported by HDMI2USB firmware between multiple different modes (programming, webcam, etc).
Apache License 2.0
10 stars 13 forks source link

Add a "--version" to download-firmware script. #91

Open mithro opened 6 years ago

Nancy-Chauhan commented 6 years ago

@mithro Sir I have analysed that HDMI2USB-mode-switch/bin/download-prebuilt-firmware.py is responsible for downloading the firmware script and further analysed that adding --version to parseargs() can help us to solve this issue ? I want to ask you whether I am thinking in right direction or not ? can you provide me further detail about this issue . I will be thankful to you for this

CarlFK commented 6 years ago

Nancy, yes, please do this.

we should probably use the same 'framework' as the mode-swtich command, which is here:

https://github.com/timvideos/HDMI2USB-mode-switch/blob/master/hdmi2usb/modeswitch/cli.py#L275 https://github.com/timvideos/HDMI2USB-mode-switch/blob/master/hdmi2usb/modeswitch/_version.py

also, maybe we should move download-firmware.py into this dir.

GitHub
timvideos/HDMI2USB-mode-switch
HDMI2USB-mode-switch - Tool for switching boards supported by HDMI2USB firmware between multiple different modes (programming, webcam, etc).
GitHub
timvideos/HDMI2USB-mode-switch
HDMI2USB-mode-switch - Tool for switching boards supported by HDMI2USB firmware between multiple different modes (programming, webcam, etc).
Nancy-Chauhan commented 6 years ago

@CarlFK sir As I analyse the issue we have to just add latest version (which is to be downloaded and make change in parseargs() as I have done in line no. 93 (https://paste.ubuntu.com/p/wvxkbHQPdS/) and make necessary change in make corresponding change in image_url please correct me if I am wrong . so that I can open pull request for it soon.

https://paste.ubuntu.com/p/wvxkbHQPdS/

Ubuntu Pastebin
Ubuntu Pastebin
CarlFK commented 6 years ago

"--version" the version of the download script, not the version of firmware available.

I am going to be somewhat unavailable for the next 5 days, I suggest you submit a pull request sooner and will have a look.

On Mon, Mar 19, 2018, 12:46 PM Nancy-Chauhan notifications@github.com wrote:

@CarlFK https://github.com/carlfk sir As I analyse the issue we have to just add latest version (which is to be downloaded and make change in parseargs() as I have done in line no. 93 ( https://paste.ubuntu.com/p/wvxkbHQPdS/) and make necessary change in make corresponding change in image_url please correct me if I am wrong . so that I can open pull request for it soon.

https://paste.ubuntu.com/p/wvxkbHQPdS/

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/timvideos/HDMI2USB-mode-switch/issues/91#issuecomment-374303626, or mute the thread https://github.com/notifications/unsubscribe-auth/AABauTBTGBzSt9877XeAq4GUPU9KSarOks5tf-75gaJpZM4RlPnv .

GitHub
CarlFK (Carl Karsten)
CarlFK has 50 repositories available. Follow their code on GitHub.
Ubuntu Pastebin
Ubuntu Pastebin
GitHub
Build software better, together
GitHub is where people build software. More than 27 million people use GitHub to discover, fork, and contribute to over 80 million projects.