timvideos / edid.tv

EDID Database Website
GNU General Public License v2.0
26 stars 7 forks source link

Upgrade to Django 1.11 #24

Closed pp3345 closed 5 years ago

pp3345 commented 5 years ago

This took quite a bit longer than expected and still isn't 100% complete but this is what I have so far (WIP, so please don't merge yet). Django 1.11 is the latest release that still supports Python 2.7.

@mithro It seems that Travis CI is currently turned off for this repo, could you please enable it again?

TODO

todo[bot] commented 5 years ago

accessing protected properties is evil

https://github.com/timvideos/edid.tv/blob/e2118235a918be707bdb203d6b9bb5a240403a94/frontend/views.py#L314-L318


This comment was generated by todo based on a TODO comment in e2118235a918be707bdb203d6b9bb5a240403a94 in #24. cc @pp3345.
todo[bot] commented 5 years ago

moar evil

https://github.com/timvideos/edid.tv/blob/e2118235a918be707bdb203d6b9bb5a240403a94/frontend/views.py#L328-L332


This comment was generated by todo based on a TODO comment in e2118235a918be707bdb203d6b9bb5a240403a94 in #24. cc @pp3345.
pp3345 commented 5 years ago

Selenium should be fine again now. The previous integration basically stopped working with Firefox 43, GeckoDriver is now required for testing with Firefox. Most tests were quite flaky, I've fixed that by introducing proper explicit wait conditions. One of the tests is still failing but that's related to the other revision-related test cases.

mithro commented 5 years ago

This is looking pretty good for me!

pp3345 commented 5 years ago

All issues except for the Makefile are resolved now and all tests are green.

@mithro As previously asked, could you please enable Travis again? I'm also thinking about removing the Makefile altogether as I fail to see the point of having one for a simple Python/Django web project. We could just add the few commands that are actually needed for quick-starting into the project to the README instead. What do you think?

mithro commented 5 years ago

Travis-CI reactivated. You will need a to push something to get it to run however.

pp3345 commented 5 years ago

@mithro Thanks for enabling Travis. What do you think about the Makefile question?

mithro commented 5 years ago

I think having a Makefile is easier then having to always look things up in the README file. I would like to keep it unless you feel strongly otherwise?

pp3345 commented 5 years ago

No, I am fine with keeping the Makefile. I've fixed the remaining stuff and also updated the Travis configuration. The Travis builds are failing because of some pep8 and pylint stuff which I feel belongs into another PR. This PR is ready from my side.

pp3345 commented 5 years ago

@mithro friendly ping :)

mithro commented 5 years ago

Merged!